Default to CRT HTTP Client for all EventStreams #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nateprewitt
reviewed
Mar 6, 2025
Comment on lines
+150
to
+151
| writer.addDependency(SmithyPythonDependency.SMITHY_HTTP); | ||
| writer.addDependency(SmithyPythonDependency.AIO_HTTP); |
Contributor
There was a problem hiding this comment.
rereading this, I think this is slightly incorrect, but assuming the other conditional triggers now, it isn't a hard blocker.
What we want this to look like eventually is:
smithy-http[awscrt]
or
smithy-http[aiohttp]
where the http client version is declared in smithy-http and we're not taking additional dependencies. I think we can track that as follow up work, I'm not sure .withOptionalDependencies("aiohttp") was actually working before.
This was referenced Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Based on internal discussion, use the CRT HTTP Client as the default for all event streams - single and bi-directional. This provides better forwards compatibility when a service moves from single directional event streams to bi-directional, but is not potentially the right long term solution.
This PR also adds the default HTTP client as an explicit dependency to improve the out of the box experience.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.